: oss: now we have rpath remove LD_LIBRARY_PATH #1617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… libpython3.10.so.1.0 (meta-pytorch#1614) Summary: inject an rpath into `_rust_bindings.so`. we put `-C link-args=-Wl,-rpath,<dir>` into `RUST_FLAGS`. (directs the dynamic linker at runtime to search <dir> for shared libraries like libpython3.10.so.1.0). Differential Revision: D84991141
…ath (meta-pytorch#1615) Summary: add a linux-only test to verify that `_rust_bindings.so` resolves `libpython` via its injected rpath. the test imports the extension and runs `ldd` to confirm `libpython` is found in the ELF dependency list. Differential Revision: D84992101
Summary: we now resolve dynamic link dependencies using rpath. Differential Revision: D85015990
meta-cla
bot
added
the
CLA Signed
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85015990. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: we now resolve dynamic link dependencies using rpath.
Differential Revision: D85015990